fix(scopes): Add more typing info to Scope.update_from_kwargs's "contexts" #4080
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exts" The original type hint could be understood as a one-level `dict` of `str` to `Any`, when in fact, it's a two-level dict.
antonpirker
approved these changes
Feb 20, 2025
Contributor
antonpirker
left a comment
antonpirker
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the contribution @Perlence!
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4080 +/- ##
==========================================
- Coverage 79.57% 79.53% -0.04%
==========================================
Files 140 140
Lines 15512 15512
Branches 2628 2628
==========================================
- Hits 12343 12338 -5
- Misses 2335 2337 +2
- Partials 834 837 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original type hint could be understood as a one-level
dictofstrtoAny, when in fact, it's a two-level dict.